Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] Cannot return IAngularEvent in $emit wrapper unfortunately. #18296

Merged
merged 2 commits into from Nov 12, 2021
Merged

[Vue] Cannot return IAngularEvent in $emit wrapper unfortunately. #18296

merged 2 commits into from Nov 12, 2021

Conversation

diosmosis
Copy link
Member

Description:

The result does not appear to be used by angularjs so it should be fine.

@sgiehl the requested fix

Review

@diosmosis diosmosis added the Needs Review PRs that need a code review label Nov 11, 2021
@diosmosis diosmosis added this to the 4.6.0 milestone Nov 11, 2021
peterhashair
peterhashair approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@peterhashair peterhashair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that is related to Travis tests

@diosmosis diosmosis merged commit 0e53a20 into 4.x-dev Nov 12, 2021
@diosmosis diosmosis deleted the vue-event-fix branch November 12, 2021 02:40
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhashair peterhashair peterhashair approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @peterhashair @justinvelluppillai