@diosmosis opened this Pull Request on November 10th 2021 Member

Description:

Noticed that my understanding of how Vue implements scoped styles was incorrect. I assumed it worked like Emotion, but for production Vue will generate a CSS file. So we can use scoped styles w/o increasing the JS bundle size.

Note, however, that theme variables defined in the normal Matomo asset pipeline are not available here, so it will be of limited use. For the migration I won't be moving them.

Review

@sgiehl commented on November 10th 2021 Member

@diosmosis Could you maybe add some scoped css to the example vue component? If we support it, would be good to have that there I guess.

@diosmosis commented on November 10th 2021 Member

@sgiehl good idea, added it :+1:

This Pull Request was closed on November 11th 2021
Powered by GitHub Issue Mirror