[Vue] use .development suffix for watch files and gitignore them #18286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… needed to constantly rebuild before pushing
|
I think this is good merge, will fix the conflicts 👍 |
peterhashair
approved these changes
Nov 11, 2021
|
Unfortunately it won't fix the conflicts with production JS, just means committing/pushing locally will be a bit easier. |
justinvelluppillai
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I noticed in the Vue workflow, when running vue:build --watch, the UMD files are overwritten. This causes git to notice and requires a vue:build before a dev can push. This PR changes the output file name of files built with --watch to have a .development suffix and adds paths like these to the .gitignore so rebuilding JS locally before pushing isn't always needed.
Review