@diosmosis opened this Pull Request on November 9th 2021 Member

Description:

events can sometimes be posted before angular is ready. Waiting for angular seems to fix the issue.

Review

@sgiehl commented on November 9th 2021 Member

seems the vue files weren't updated for some reason. Will merge in latest 4.x-dev, maybe that triggers the build.

@sgiehl commented on November 9th 2021 Member

@diosmosis I guess I know why the vue files didn't built. The action only ran on synchronize, but seems that isn't triggered when the PR is opened. As you didn't push any further commits afterwards it was never triggered. I've added a commit so the action should also run when a PR is opened. Feel free to have a look and merge if you think that's fine.

@diosmosis commented on November 9th 2021 Member

@sgiehl I see, thanks for pushing a fix!

This Pull Request was closed on November 9th 2021
Powered by GitHub Issue Mirror