[Vue] wait for angular to be initialized to post events to avoid loading race condition #18284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
added
not-in-changelog
sgiehl
approved these changes
Nov 9, 2021
|
seems the vue files weren't updated for some reason. Will merge in latest 4.x-dev, maybe that triggers the build. |
|
@diosmosis I guess I know why the vue files didn't built. The action only ran on |
|
@sgiehl I see, thanks for pushing a fix! |
sgiehl
reviewed
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
events can sometimes be posted before angular is ready. Waiting for angular seems to fix the issue.
Review