Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stray vendor files in File Integrity report #18282

Closed
alimony opened this issue Nov 8, 2021 · 1 comment
Closed

Stray vendor files in File Integrity report #18282

alimony opened this issue Nov 8, 2021 · 1 comment
Labels
answered For when a question was asked and we referred to forum or answered it. Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced.

Comments

@alimony
Copy link

alimony commented Nov 8, 2021

I get stray files in the File Integrity report but that seems to have popped up as part of an upgrade or similar.

Expected Behavior

No errors in integrity check, as I haven't modified any files.

Current Behavior

I get three stray files.

Possible Solution

Ignore these in the check, if they are now expected to pop up as part of other packages.

Steps to Reproduce (for Bugs)

  1. Upgrade to latest version of Matomo (4.5.0)

Context

Files were found in your Matomo, but we didn't expect them.
--> Please delete these files to prevent errors. <--

File to delete: vendor/php-di/php-di/.gitstats.yml
File to delete: vendor/php-di/php-di/.phpstorm.meta.php
File to delete: vendor/twig/twig/.php_cs.dist

Your Environment

  • Matomo Version: 4.5.0
  • PHP Version: 7.4.3
  • Server Operating System: Ubuntu 20.04
@alimony alimony added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Nov 8, 2021
@sgiehl
Copy link
Member

sgiehl commented Nov 8, 2021

Hi @alimony
Thanks for your report. Those files were actually not part of the last release. It seems for some reason they might have been included in a former release and were not removed on update in your case.
We will improve our script to ensure they won't be included in future releases.
For your setup please simply remove the files manually. Those files won't be included in future releases.

@sgiehl sgiehl closed this as completed Nov 8, 2021
@sgiehl sgiehl added the answered For when a question was asked and we referred to forum or answered it. label Nov 8, 2021
sgiehl added a commit to matomo-org/matomo-package that referenced this issue Nov 8, 2021
@sgiehl
Remove some more unwanted files from builds
3e8a6f2 
refs matomo-org/matomo#18282
@sgiehl sgiehl mentioned this issue Nov 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
answered For when a question was asked and we referred to forum or answered it. Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alimony @sgiehl