@samjf opened this Pull Request on November 7th 2021 Contributor

Description:

issue: d2405

There has been a lot of tracker general cache invalidation occurring seemingly needlessly. It seems to come down to the archive invalidation clearing out the cache when trying to forget (remove) the remembered dates that need to be reArchived. This appears to be an accidental regression based off the comment.

I've removed the cache clearing from inside forgetRememberedArchivedReportsToInvalidate method. Both uses of this method will clear the general cache just after this method anyway.

I can't think of any cases that this should cause a problem. The only think I can think is that doing it perhaps only moments later (after the loop) might increase the probability of clearing out something that was just cached. Even if it was the case but picking a time between the two seems arbitrary. In that case it would be preferable to clear the cache before the loop.

Review

This Pull Request was closed on November 7th 2021
Powered by GitHub Issue Mirror