Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is a possible solution for #18232
I have taken "remove this feature" to mean remove the code involved and not simply turn it off.
Rather than trying to revert the commits in the original PR I opted to go through the changes and remove what didn't appear to be required/useful.
Firstly, I did it this way as there are changes made after the initial PR was merged like translations of the "refer us" popup's strings and possibly other changes.
Secondly, some of the changes from the original PR may still be useful. For example in plugins/Feedback/Feedback.php renderViewsAndAddToPage() can still support multiple popups if it needs to do that again.
I am unsure if there is another process for the removal of unused strings from language files.
Let me know if anything about this is incorrect and I will be happy to fix it :)
Review