@andyjdavis opened this Pull Request on November 7th 2021 Contributor

Description:

This is a possible solution for https://github.com/matomo-org/matomo/issues/18232

I have taken "remove this feature" to mean remove the code involved and not simply turn it off.

Rather than trying to revert the commits in the original PR I opted to go through the changes and remove what didn't appear to be required/useful.

Firstly, I did it this way as there are changes made after the initial PR was merged like translations of the "refer us" popup's strings and possibly other changes.

Secondly, some of the changes from the original PR may still be useful. For example in plugins/Feedback/Feedback.php renderViewsAndAddToPage() can still support multiple popups if it needs to do that again.

I am unsure if there is another process for the removal of unused strings from language files.

Let me know if anything about this is incorrect and I will be happy to fix it :)

Review

@Findus23 commented on November 7th 2021 Member

I am unsure if there is another process for the removal of unused strings from language files.

Just FYI, if you remove them from en.json, weblate should automatically remove them from all other languages in its next PR

@sgiehl commented on November 7th 2021 Member

Actually it would be better to only adjust them in en.json, as otherwise Weblate might get merge conflicts if there were changes in that file in any language.

@peterhashair commented on November 7th 2021 Contributor

@andyjdavis Thanks for the PR. I merged your changes to my PR if that's ok. Otherwise, there will be conflicts.

@andyjdavis commented on November 8th 2021 Contributor

@peterhashair no problem. Shall I just close this PR?

Actually it would be better to only adjust them in en.json, as otherwise Weblate might get merge conflicts if there were changes in that file in any language.

@sgiehl is it still worth doing this? I assume that would now need to happen in @peterhashair's PR.

@peterhashair commented on November 8th 2021 Contributor

@andyjdavis sure you can close that PR if that ok, also can I put your name for that issue on the next release :).

@andyjdavis commented on November 8th 2021 Contributor

Closing this PR. I hope it was useful :)

@peterhashair commented on November 8th 2021 Contributor

@andyjdavis it's really helpful, 99.99% using your code, just some tiny updates :), you are on the next release list :)

This Pull Request was closed on November 8th 2021
Powered by GitHub Issue Mirror