Description:

Using the scope $destroy event seems to destroy the vue component at the wrong time resulting in vue elements disappearing while the angularjs adapters are still around. I suspect it's because the $destroy scope event is broadcasted, but wasn't able to confirm. Now we destroy the vue element only if the angularjs element is about to be removed from the dom.

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed