Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode goal top dimension values #18267

Merged
merged 3 commits into from Nov 15, 2021
Merged

Decode goal top dimension values #18267

merged 3 commits into from Nov 15, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 3, 2021

Description:

While testing another issue I came across this incorrectly decoded value:

image

Seems it is safe to simply apply the rawSafeDecoded filter. For testing purpose I've change one country name so it includes some malicious content. It's now displayed like this:

image

Review

@sgiehl sgiehl added Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review labels Nov 3, 2021
@sgiehl sgiehl added this to the 4.6.0 milestone Nov 3, 2021
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Nov 11, 2021
@sgiehl sgiehl removed the Stale The label used by the Close Stale Issues action label Nov 11, 2021
@sgiehl sgiehl merged commit 96e5eca into 4.x-dev Nov 15, 2021
@sgiehl sgiehl deleted the fixgoaltopdimescaping branch November 15, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants