Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support downloading system tests from plugins #18263

Merged
merged 4 commits into from Nov 4, 2021
Merged

Support downloading system tests from plugins #18263

merged 4 commits into from Nov 4, 2021

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 3, 2021

Description:

Works same way as syncing UI test screenshots.

Review

@tsteur tsteur added the Needs Review PRs that need a code review label Nov 3, 2021
@tsteur tsteur added this to the 4.6.0 milestone Nov 3, 2021
@sgiehl
Copy link
Member

sgiehl commented Nov 4, 2021

@tsteur The download now actually works. But it will always sync the files into the core test folder. As normally someone wants to sync the files into the plugin directly, might be good to change that a bit. I'll try to add another commit to make that possible.

@tsteur tsteur merged commit 1e15794 into 4.x-dev Nov 4, 2021
@tsteur tsteur deleted the customplugins branch November 4, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants