Upgrade szymach/c-pchart from v2.0 to 3.0 to support PHP8.1 #18260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinvelluppillai
added
the
not-in-changelog
justinvelluppillai
changed the title
sgiehl
approved these changes
Nov 3, 2021
There was a problem hiding this comment.
@justinvelluppillai might be good not to use / in branch names. Seems that makes some problems with the build artifacts for the branch.
Nevertheless the UI test failures for the PR build seem unrelated. So guess this should be good to merge.
plugins/PrivacyManager/tests/Integration/PrivacyManagerTest.php
Outdated
Show resolved
Hide resolved
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.
Review