Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more plugins as submodules #18256

Open
tsteur opened this issue Nov 2, 2021 · 3 comments
Open

Add more plugins as submodules #18256

tsteur opened this issue Nov 2, 2021 · 3 comments
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. Technical debt Issues the will help to reduce technical debt
Milestone
5.x.0 - Priority ...

Comments

@tsteur
Copy link
Member

tsteur commented Nov 2, 2021

We just noticed that there are few plugins missing as submodules:

  • Migration
  • GoogleAnalyticsImporter
  • EnvironmentVariables
  • ForceSSL
  • Invalidate Reports
  • JS Tracker Custom
  • Custom Translations

Can/should we add these as submodules maybe too to ensure we notice when we break these plugins? Not sure if it would cause tests to go a lot longer. Some of them also don't have tests.

Some of them are under the InnoCraft user. I suppose we could still add them? Or maybe otherwise move them to matomo-org if that be an issue?
@tsteur tsteur added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Nov 2, 2021
@tsteur tsteur added this to the 4.7.0 milestone Nov 2, 2021
@sgiehl
Copy link
Member

sgiehl commented Nov 2, 2021

All plugins having tests should actually always run their tests against latest 4.x-dev branch. Imho it might be enough to run those tests regularly to ensure nothing breaks. Checking those builds before a release of Matomo might actually be enough.

@tsteur
Copy link
Member Author

tsteur commented Nov 2, 2021

@sgiehl are you saying we should remove all plugin submodules?

@sgiehl
Copy link
Member

sgiehl commented Nov 2, 2021

Not all. The only benefit I see on having the submodules is that we might be able to identify potential issues that might occur when plugin are available prior to installation or their code is updated together with core. See my last PRs in AnonymousTracking plugin. But those issues should be rare and unlikely and not worth the effort.

Btw Removing the submodules would mean updating a lot tests. But if we have set up a good process to check all plugins before we release a new version of Matomo we could probably do that.
For now it might be easier not to do that.

@mattab mattab added the Technical debt Issues the will help to reduce technical debt label Dec 11, 2023
@GTVolk GTVolk mentioned this issue Apr 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. Technical debt Issues the will help to reduce technical debt
Projects
None yet
Milestone
5.x.0 - Priority issues
Development

No branches or pull requests
3 participants
@tsteur @mattab @sgiehl