@peterhashair opened this Pull Request on November 2nd 2021 Contributor

Description:

The pipeline test should auto-cancel the previous build, restart the new build job, the test contains PHP, UI, and javascript tests.

Split test into more parts, it reduces 10mins. Can do more, but I haven't looked at it

Server using php -S 80 and php -S 3000. keep 2 ports is because PHP can only start on one port curl exec the other. To pass some send HTTP-related test.

Currently using Mariadb and tmpf memory setup to speed the process, but seems like failed some of the MySQL-related tests. some are being skipped, some are fixed.

Still have quite a few screenshots that failed. Currently, the failed UI is in the artifact, can be downloaded from here,
image
would be great, if we can config the build.matomo.org to do a comparison. so can easily identify the failed reason.

Review

@peterhashair commented on November 3rd 2021 Contributor

@tsteur probably needs help for setup the UI artifact upload. It seems like all the php and js test are passed, just the UI tests.

@peterhashair commented on November 4th 2021 Contributor

@sgiehl I actually download the failed UI, but it seems like there is no different(did a comparsion locally through image6), to expected UI. Can we upload the failed UI to https://builds-artifacts.matomo.org/ do a comparison there?

@peterhashair commented on November 8th 2021 Contributor

@sgiehl @tsteur should we set up the artifact upload keys in the GitHub action. Make the comparison with failed UIs on build.matomo.org. I download the failed images and used resemble.js locally for comparison, but it seems there is no difference somehow.

@tsteur commented on November 8th 2021 Member

@peterhashair I configured it
image

@peterhashair commented on November 8th 2021 Contributor

@tsteur @sgiehl I guess we need to build a GithubProvider.php see here.https://builds-artifacts.matomo.org/matomo-org/matomo/4.x-dev/1434046939/ https://builds-artifacts.matomo.org/${{ github.repository }}/${{ github.event.pull_request.base.ref }}/${{ github.run_id }}/" that return an error

@sgiehl commented on November 8th 2021 Member

I guess we need to build a GithubProvider.php

@peterhashair feel free to give that a try and create a PR for that. You should have access to the ui-tests-viewer repo I guess.
But guess we need to find a way how to distinguish between travis and github based on the url maybe in order to choose the correct provider.

@peterhashair commented on November 9th 2021 Contributor

add merge-head.yml. it syn with the current head, keep the branch updated.

@peterhashair commented on November 9th 2021 Contributor

@sgiehl that review all make sense let me update those. Also, I got this https://github.com/matomo-org/ui-tests-viewer/pull/36 working on my local, figure out why the failed UI are there, I think it's a simple fix, most of them are logo image blocked, IP related, and 'PHP version related.

@github-actions[bot] commented on November 25th 2021 Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

Powered by GitHub Issue Mirror