remove feedback links #18253
Closed
remove feedback links #18253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 2, 2021 11:50
remove feedback links
update screen shot
peterhashair
added
Needs Review
bx80
suggested changes
Nov 3, 2021
There was a problem hiding this comment.
@peterhashair If I set the Feedback.needFeedbackReminder.root database option to a date in the past then the 'Like Matomo?' popup is still shown on page refresh.
remove feedback popup
|
@bx80 thanks for pointing that out. Removed the popup. |
|
@peterhashair If this one is integrated in another PR, shall we close it and only review the other one, when it's done. Or are you planning to rebase the other PR, once this one would be reviewed and merged? |
|
@sgiehl yes, about to close that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes: #18250
remove feedback links. Be aware this plugin is already covert to the VUE solution.
This PR is actually merged into #18262. They basically does similar thing Otherwise there will be conflicts.
Review