[Vue] make sure transcluded content is processed before query selectors in EnrichedHeadline #18242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
added
not-in-changelog
|
@diosmosis seems the vue build doesn't work anymore. Seems due to the ignored map files. See https://github.com/matomo-org/matomo/runs/4044312962?check_suite_focus=true |
|
Tested it locally and it seems to work nicely. So once the built vue files are up to date, this would be good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #18238 cc @tsteur
Seems at the point the vue component is mounted, angularjs has not processed the transclude content. The timeout seems to fix this.
Review