Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix annotations for StackedBarEvolution charts #18236

Merged
merged 2 commits into from Oct 29, 2021
Merged

Fix annotations for StackedBarEvolution charts #18236

merged 2 commits into from Oct 29, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Oct 28, 2021

Description:

fixes #18231

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Oct 28, 2021
@sgiehl sgiehl added this to the 4.6.0 milestone Oct 28, 2021
@tsteur
Copy link
Member

tsteur commented Oct 28, 2021

@sgiehl works, the UI tests will need to be updated though https://builds-artifacts.matomo.org/matomo-org/matomo/4.x-dev/50471/

bx80
bx80 approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me 👍

@sgiehl sgiehl merged commit fc82445 into 4.x-dev Oct 29, 2021
@sgiehl sgiehl deleted the fix18231 branch October 29, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bx80 bx80 bx80 approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

Fix annotations for "Behaviour > Performance" StackedBarEvolution charts
3 participants
@sgiehl @tsteur @bx80