Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to keep sorting order consistent across all PHP versions for Live.getLastVisitsDetails API #18235

Merged
merged 2 commits into from Nov 9, 2021
Merged

Changes to keep sorting order consistent across all PHP versions for Live.getLastVisitsDetails API #18235

merged 2 commits into from Nov 9, 2021

Conversation

AltamashShaikh
Copy link
Contributor

Description:

Changes to keep sorting order consistent across all php versions.
Fixes: #18234

Review

@AltamashShaikh AltamashShaikh added the Needs Review PRs that need a code review label Oct 28, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2021

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Nov 9, 2021
justinvelluppillai
justinvelluppillai approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@justinvelluppillai justinvelluppillai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty safe and nothing obvious breaking for me.

@justinvelluppillai justinvelluppillai merged commit 911ad61 into 4.x-dev Nov 9, 2021
@justinvelluppillai justinvelluppillai deleted the 18234-fix-sort-issue branch November 9, 2021 03:02
@GTVolk GTVolk mentioned this pull request Apr 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvelluppillai justinvelluppillai justinvelluppillai approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review Stale The label used by the Close Stale Issues action
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Live.getLastVisitsDetails API sort order different for PHP8
2 participants
@AltamashShaikh @justinvelluppillai