Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added code to filter response for API.getReportPagesMetadata and API.getWidgetMetadata #18233

Merged
merged 3 commits into from Nov 2, 2021
Merged

Added code to filter response for API.getReportPagesMetadata and API.getWidgetMetadata #18233

merged 3 commits into from Nov 2, 2021

Conversation

AltamashShaikh
Copy link
Contributor

Added code to filter response for API.getReportPagesMetadata and API.getWidgetMetadata.
Issue: #DEV-2366

Description:

Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.

Review

@AltamashShaikh AltamashShaikh added this to the 4.6.0 milestone Nov 2, 2021
@AltamashShaikh AltamashShaikh added the Needs Review PRs that need a code review label Nov 2, 2021
@AltamashShaikh AltamashShaikh marked this pull request as ready for review November 2, 2021 04:59
sgiehl
sgiehl approved these changes Nov 2, 2021
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as expected. 👍

@sgiehl sgiehl added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels Nov 2, 2021
@sgiehl sgiehl merged commit 1ff7444 into 4.x-dev Nov 2, 2021
@sgiehl sgiehl deleted the DEV-2366-filter_API_Response branch November 2, 2021 09:44
@GTVolk GTVolk mentioned this pull request Apr 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AltamashShaikh @sgiehl