Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix annotations for "Behaviour > Performance" StackedBarEvolution charts #18231

Closed
robles-design opened this issue Oct 27, 2021 · 2 comments · Fixed by #18236
Closed

Fix annotations for "Behaviour > Performance" StackedBarEvolution charts #18231

robles-design opened this issue Oct 27, 2021 · 2 comments · Fixed by #18236
Assignees
@sgiehl
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
4.6.0

Comments

@robles-design
Copy link

Expected Behavior

Annotations should show up below Behaviour > Performance.

Current Behavior

Annotations doesn't show up below Behaviour > Performance.

Steps to Reproduce (for Bugs)

matomo-annotations-not-working.mp4

Context

I work with annotations to analyze websites changes to see if they have an impact or not.

Your Environment

Matomo-Version: 4.5.0
MySQL-Version: 10.5.11-MariaDB-1:10.5.11+maria~focal-log
PHP-Version: 8.0.10
@robles-design robles-design added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Oct 27, 2021
@bx80
Copy link
Contributor

bx80 commented Oct 27, 2021

Hi @robles-design, thanks for raising this issue and taking the time to make a video, that's very helpful. I've managed to recreate the problem and it does seem to be a bug.

@bx80 bx80 added Bug For errors / faults / flaws / inconsistencies etc. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Oct 27, 2021
@sgiehl
Copy link
Member

sgiehl commented Oct 28, 2021 •
edited

That's quite easy to explain. Annotations are currently hard coded only available for evolution charts, but the performance chart has another graph type. Should be quite simple to fix that. Will have a quick look...

@sgiehl sgiehl mentioned this issue Oct 28, 2021
Merged
11 tasks
@sgiehl sgiehl self-assigned this Oct 28, 2021
@sgiehl sgiehl added this to the 4.6.0 milestone Oct 28, 2021
@justinvelluppillai justinvelluppillai changed the title Annotations doesn't show up below Behaviour > Performance Fix annotations for "Behaviour > Performance" StackedBarEvolution charts Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
4.6.0
Development

Successfully merging a pull request may close this issue.

Fix annotations for StackedBarEvolution charts matomo-org/matomo
3 participants
@sgiehl @robles-design @bx80