@sgiehl opened this Pull Request on October 27th 2021 Member

Description:

This PR contains the following changes:

The row evolution will now show the goal metrics when a row evolution is opened from

  • a report on a goals report page (specific or overview)
  • the ecommerce sales page
  • or any other report that has been switched to the goals visualization

Additionally it fixes this issues that existed before:

fixes #3883

Review

@sgiehl commented on November 2nd 2021 Member

This can be already reviewed if someone has some time. I'll try to add some additional UI tests tomorrow that cover the "bugs" I mentioned in the description to ensure they won't reoccur in the future.

@sgiehl commented on November 3rd 2021 Member

@tsteur updated the caching and also added some more tests for row evolution.
Also decided to move some of the goals related UI tests to the Goals plugin. Imho it's easier to have smaller units of tests than everything in the big UIIntegration class, as it's easier to execute those single tests locally then.

This Pull Request was closed on November 3rd 2021
Powered by GitHub Issue Mirror