New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show correct metrics in row evolution triggered from goal view tables #18228
Conversation
…atable might not yet be available, but is required
…d from a goal viz
… a row evolution without a linked datatable
This can be already reviewed if someone has some time. I'll try to add some additional UI tests tomorrow that cover the "bugs" I mentioned in the description to ensure they won't reoccur in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works 👍 Code looks good too, left only one comment
@tsteur updated the caching and also added some more tests for row evolution. |
Description:
This PR contains the following changes:
The row evolution will now show the goal metrics when a row evolution is opened from
Additionally it fixes this issues that existed before:
When a row evolution was opened from a goals report page the url parameter contained the
idGoal
, loading this URL again resulted in an error page, as the previously used javascript did not remove theidGoal
before sending the request. See eg https://demo.matomo.cloud/index.php?module=CoreHome&action=index&idSite=1&period=day&date=yesterday#?idSite=1&period=day&date=yesterday&segment=&category=Goals_Goals&subcategory=4&popover=RowAction$3ARowEvolution$3AReferrers.getReferrerType$3A$257B$2522idGoal$2522$253A$25224$2522$257D$3A$40WebsitesIn a multi row evolution it is possible to choose the metric. Choosing the metric caused loosing any possible id parameters before, as the
extraParameters
were reset for this action. This caused a similar error as above, as an id param might be missing. This can be reproduced when e.g. switching the metric in a multi row evolution for forms: https://demo.matomo.cloud/index.php?module=CoreHome&action=index&idSite=1&period=day&date=yesterday#?idSite=1&period=day&date=yesterday&segment=&category=FormAnalytics_Forms&subcategory=7&popover=RowAction$3ARowEvolution$3AFormAnalytics.getPageUrls$3A$257B$2522action$2522$253A$2522getMultiRowEvolutionPopover$2522$252C$2522idForm$2522$253A$25227$2522$257D$3A$40divezone.net$252Fjobs$252Fapply$252Fchinese-speaking-ssi-instructor-or-padi-instructor$2C$40divezone.net$252Fjobs$252Fapply$252Fdivemaster-2fixes #3883
Review