Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show correct metrics in row evolution triggered from goal view tables #18228

Merged
merged 14 commits into from Nov 3, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Oct 27, 2021

Description:

This PR contains the following changes:

The row evolution will now show the goal metrics when a row evolution is opened from

  • a report on a goals report page (specific or overview)
  • the ecommerce sales page
  • or any other report that has been switched to the goals visualization

Additionally it fixes this issues that existed before:

fixes #3883

Review

@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 27, 2021
@sgiehl sgiehl added this to the 4.6.0 milestone Oct 27, 2021
@sgiehl
Copy link
Member Author

sgiehl commented Nov 2, 2021

This can be already reviewed if someone has some time. I'll try to add some additional UI tests tomorrow that cover the "bugs" I mentioned in the description to ensure they won't reoccur in the future.

@sgiehl sgiehl marked this pull request as ready for review November 2, 2021 18:52
@sgiehl sgiehl added the Needs Review PRs that need a code review label Nov 2, 2021
Copy link
Member

@tsteur tsteur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works 👍 Code looks good too, left only one comment

plugins/API/RowEvolution.php Outdated Show resolved Hide resolved
@sgiehl
Copy link
Member Author

sgiehl commented Nov 3, 2021

@tsteur updated the caching and also added some more tests for row evolution.
Also decided to move some of the goals related UI tests to the Goals plugin. Imho it's easier to have smaller units of tests than everything in the big UIIntegration class, as it's easier to execute those single tests locally then.

@tsteur tsteur merged commit 6b6f572 into 4.x-dev Nov 3, 2021
@tsteur tsteur deleted the fix3883 branch November 3, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
2 participants