Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] remove and ignore js map files since they do not help in production #18223

Merged
merged 2 commits into from Oct 27, 2021
Merged

[Vue] remove and ignore js map files since they do not help in production #18223

merged 2 commits into from Oct 27, 2021

Conversation

diosmosis
Copy link
Member

Description:

As title.

Review

@diosmosis diosmosis added the Needs Review PRs that need a code review label Oct 27, 2021
@diosmosis diosmosis added this to the 4.6.0 milestone Oct 27, 2021
sgiehl
sgiehl approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diosmosis looks good. Feel free to resolve the conflicts and merge afterwards

@diosmosis diosmosis merged commit 51c1500 into 4.x-dev Oct 27, 2021
@diosmosis diosmosis deleted the vue-remove-map-files branch October 27, 2021 18:09
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @sgiehl @justinvelluppillai