Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] Always enable CoreVue. #18222

Merged
merged 2 commits into from Oct 27, 2021
Merged

[Vue] Always enable CoreVue. #18222

merged 2 commits into from Oct 27, 2021

Conversation

diosmosis
Copy link
Member

Description:

As title.

Review

@diosmosis diosmosis added the Needs Review PRs that need a code review label Oct 26, 2021
@diosmosis diosmosis added this to the 4.6.0 milestone Oct 26, 2021
sgiehl
sgiehl approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. will update the expected ui files before merging

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels Oct 27, 2021
@sgiehl sgiehl merged commit 88cbc95 into 4.x-dev Oct 27, 2021
@sgiehl sgiehl deleted the vue-always-enable-core-vue branch October 27, 2021 13:36
@diosmosis
Copy link
Member Author

@sgiehl thanks for the build fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @sgiehl