@bx80 opened this Pull Request on October 26th 2021 Contributor

Description:

Fixes #2030

Adds new reports for goal conversions by page url, page title and entry page to the goals overview, see the detailed specification in #2030 for full details.

System tests have now been added.

Review

@github-actions[bot] commented on November 12th 2021 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@justinvelluppillai commented on November 22nd 2021 Contributor

@bx80 anything needed here to progress this?

@bx80 commented on November 22nd 2021 Contributor

@justinvelluppillai Just needs reviewing.

@bx80 commented on November 23rd 2021 Contributor

@sgiehl Looks like I managed to come up with a query in LogAggregator::queryConversionsByPageView() that worked in MariaDB but not in MySQL with strict mode. :facepalm:
I've committed a fix and tested the query on both MariaDB and MySQL, hopefully that sorts the error you encountered.

Powered by GitHub Issue Mirror