Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoreAdminHome string changes #18220

Merged
merged 2 commits into from Oct 28, 2021

Conversation

comradekingu
Copy link
Contributor

Description:

Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.

Review

@sgiehl sgiehl added c: i18n For issues around internationalisation and localisation. Needs Review PRs that need a code review labels Oct 26, 2021
@sgiehl
Copy link
Member

sgiehl commented Oct 28, 2021

@justinvelluppillai could you maybe have a look at that one? For me the changes are looking fine, but I'm not English native speaker, so might be better if someone else has a quick look at it.

Copy link
Contributor

@justinvelluppillai justinvelluppillai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@justinvelluppillai justinvelluppillai merged commit 590165f into matomo-org:4.x-dev Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: i18n For issues around internationalisation and localisation. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants