@diosmosis opened this Pull Request on October 25th 2021 Member

Description:

This PR is based off of https://github.com/matomo-org/matomo/pull/18193.

Changes:

  • Migrate piwik-date-picker component to Vue.
  • Migrate piwik-date-range-picker component.
  • Migrate piwik-period-date-picker component.
  • Migrate piwik-expand-on-click directive and piwik-expand-on-hover directive.
  • Add event mapping support to createAngularJsAdapter().

Notes:

  • Using the composition API (doing a lot of work in setup()) vs. the options API (properties in defineComponent(...)) moreso here since it's easier when watching multiple properties at the same time (though it's still hard to do w/ Vue). Neither API is preferred over the other by the vue apparently.

image

Review

@github-actions[bot] commented on November 3rd 2021 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@diosmosis commented on November 7th 2021 Member

@sgiehl looks like tests are passing, this one should be ready to review.

@diosmosis commented on November 7th 2021 Member

Actually, there's still one issue here, I'd wait a bit.

@diosmosis commented on November 8th 2021 Member

@sgiehl this is ready for review now.

@peterhashair commented on November 8th 2021 Contributor

that looks good to me.

This Pull Request was closed on November 9th 2021
Powered by GitHub Issue Mirror