[Vue] migrate date-picker and other period-selector related components #18213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty method (all untested)
…se v-model, add event parameters to createAngularAdapter, allow translate to use variadic args or one string array + rebuild
…s in between nodes while vue 3 does not
…ndling to just reset back to the previous date since it was easier in vue to do that)
diosmosis
added
Do not close
|
@sgiehl looks like tests are passing, this one should be ready to review. |
|
Actually, there's still one issue here, I'd wait a bit. |
|
@sgiehl this is ready for review now. |
|
that looks good to me. |
sgiehl
approved these changes
Nov 8, 2021
There was a problem hiding this comment.
Left a minor comment. Besides that the code looks fine and the tests seems still to pass. Feel free to merge @diosmosis
|
|
||
| if (!(date instanceof Date)) { | ||
| try { | ||
| date = $.datepicker.parseDate('yy-mm-dd', date); |
There was a problem hiding this comment.
any reason for not using Periods/utilities/parseDate? I know it's handling some stuff more than needed, but might be good to minimize the direct usage of the datepicker methods, so it's easier to switch it at some point maybe.
There was a problem hiding this comment.
No reason, I missed this. You're right it should use the typescript method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is based off of #18193.
Changes:
Notes:
setup()) vs. the options API (properties indefineComponent(...)) moreso here since it's easier when watching multiple properties at the same time (though it's still hard to do w/ Vue). Neither API is preferred over the other by the vue apparently.Review