Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect previously selected row display count in evolution charts #18212

Merged
merged 6 commits into from Oct 26, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Oct 24, 2021

Description:

The selected row count was actually already stored in the view datatable settings, but was not used and always overwritten with the default (if not given as get parameter).

fixes #14370

Review

@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 24, 2021
@sgiehl sgiehl added this to the 4.6.0 milestone Oct 24, 2021
@sgiehl sgiehl added the Needs Review PRs that need a code review label Oct 25, 2021
@sgiehl sgiehl marked this pull request as ready for review October 25, 2021 07:22
Copy link
Member

@tsteur tsteur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked for me. I just did a whitespace change to trigger the tests. Is good to merge if tests pass ( or otherwise needs updating of tests)

@sgiehl sgiehl merged commit fa04bd8 into 4.x-dev Oct 26, 2021
@sgiehl sgiehl deleted the fix14370 branch October 26, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remember "Rows to display" user preference for Evolution graphs
2 participants