Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates davaxi/sparkline to 2.0 to PHP8.1 compatible version #18211

Merged
merged 1 commit into from Oct 25, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Oct 24, 2021

Description:

This should fix an issue on PHP 8.1. As the release includes some other changes we should wait if all tests are still passing before merging.

refs #17686

Review

@sgiehl sgiehl added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Needs Review PRs that need a code review labels Oct 24, 2021
@sgiehl sgiehl added this to the 4.6.0 milestone Oct 24, 2021
@sgiehl sgiehl mentioned this pull request Oct 24, 2021
38 tasks
@tsteur tsteur merged commit 01c70e1 into 4.x-dev Oct 25, 2021
@tsteur tsteur deleted the updatesparkline branch October 25, 2021 19:33
@justinvelluppillai justinvelluppillai changed the title Updates davaxi/sparkline to 2.0 Updates davaxi/sparkline to 2.0 to PHP8.1 compatible version Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Needs Review PRs that need a code review Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants