@hywak opened this Pull Request on October 21st 2021

Description:

https://github.com/matomo-org/matomo/issues/17686

Lot's of files are changed, but those are cosmetics changes only.

Review

@sgiehl commented on October 26th 2021 Member

@hywak would you mind merging in the latest changes from 4.x-dev branch. Travis builds should be up and running again, so we hopefully can see afterwards if all those changes break anything or not.

@sgiehl commented on October 28th 2021 Member

@hywak Seems there are a plenty of tests failing. Might be good to first looking into why the Unit tests are failing, maybe fixing those might also fix some of the other test suites:
https://app.travis-ci.com/github/matomo-org/matomo/jobs/545181203
I'm not sure when I will find some time to have a quick look myself to maybe identify some first issues, but will try to do that soon.

@hywak commented on October 28th 2021

@sgiehl I will take a look at it tomorrow or at the weekend :)

@hywak commented on October 29th 2021

@sgiehl Is there documentation on how to run tests locally?

@sgiehl commented on October 29th 2021 Member

@hywak sure. See https://developer.matomo.org/guides/tests
If you have any problems with that, feel free to ask.

@hywak commented on October 29th 2021
@sgiehl commented on October 29th 2021 Member

The System tests are still failing though. Seems to be caused by some kind of rounding issue. Guess some check doesn't do the same as before...

@github-actions[bot] commented on November 13th 2021 Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions[bot] commented on December 26th 2021 Contributor

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers

@sgiehl commented on February 18th 2022 Member

@hywak I will close this one now. I don't think we will be able to easily get this PR into a state where we can safely merge. The number of changes is simply to high to identify which are causing the test failures.
If you are still keen on contributing to Matomo, it would be very helpful to create smaller pull requests with the same changes instead. If only a couple of files are changed in each it's a lot easier to find the cause for failing tests and we will be a lot more faster in merging it...

This Pull Request was closed on February 18th 2022
Powered by GitHub Issue Mirror