Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use proper CSP headers for Overlay #18188

Merged
merged 3 commits into from Oct 22, 2021
Merged

Use proper CSP headers for Overlay #18188

merged 3 commits into from Oct 22, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Oct 20, 2021

Description:

fixes #18187

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Oct 20, 2021
@sgiehl sgiehl added this to the 4.6.0 milestone Oct 20, 2021
justinvelluppillai
justinvelluppillai approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@justinvelluppillai justinvelluppillai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed unneeded imports and now looks good to merge

@sgiehl
Copy link
Member Author

sgiehl commented Oct 22, 2021

@tsteur Might be good if we can deploy this one to cloud before 4.6.0 is released to be sure the overlay would work correct again. Otherwise it could break completely if CSP will be out of report only in 4.6.0

@sgiehl sgiehl merged commit 3643081 into 4.x-dev Oct 22, 2021
@sgiehl sgiehl deleted the overlycsp branch October 22, 2021 07:48
@tsteur
Copy link
Member

tsteur commented Oct 26, 2021

Was deployed last week so it's already on the demo @sgiehl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur left review comments

@justinvelluppillai justinvelluppillai justinvelluppillai approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

Fix possible problem with CSP in overlay feature
3 participants
@sgiehl @tsteur @justinvelluppillai