Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible problem with CSP in overlay feature #18187

Closed
tsteur opened this issue Oct 20, 2021 · 2 comments · Fixed by #18188
Closed

Fix possible problem with CSP in overlay feature #18187

tsteur opened this issue Oct 20, 2021 · 2 comments · Fixed by #18188
Assignees
@sgiehl
Labels
Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced.
Milestone
4.6.0

Comments

@tsteur
Copy link
Member

tsteur commented Oct 20, 2021 •
edited

See https://demo.matomo.cloud/index.php?module=Overlay&period=month&date=today&idSite=1#?l=https$3A$2F$2Fdivezone.net$2Fdiving$2Findonesia$3F__prod_demo$3D1$26__enterprise_demo_idsite$3D1

seeing this error
image

When we remove the report only mode in #17923 this could break the overlay feature.

Not really sure what the problem is there?
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Oct 20, 2021
@tsteur tsteur added this to the 4.6.0 milestone Oct 20, 2021
@tsteur tsteur closed this as completed Oct 20, 2021
@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. worksforme The issue cannot be reproduced and things work as intended. Bug For errors / faults / flaws / inconsistencies etc. Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. and removed Bug For errors / faults / flaws / inconsistencies etc. worksforme The issue cannot be reproduced and things work as intended. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Oct 20, 2021
@tsteur tsteur reopened this Oct 20, 2021
@justinvelluppillai
Copy link
Contributor

That default-src CSP looks wrong, like it didn't apply the allowEmbedPage directives in SecurityPolicy class

@tsteur
Copy link
Member Author

tsteur commented Oct 20, 2021

@justinvelluppillai doesn't look like this is called for the overlay feature maybe?

@sgiehl sgiehl self-assigned this Oct 20, 2021
@sgiehl sgiehl mentioned this issue Oct 20, 2021
Merged
11 tasks
@justinvelluppillai justinvelluppillai changed the title Possible problem with CSP in overlay feature Fix possible problem with CSP in overlay feature Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced.
Projects
None yet
Milestone
4.6.0
Development

Successfully merging a pull request may close this issue.

Use proper CSP headers for Overlay matomo-org/matomo
3 participants
@tsteur @justinvelluppillai @sgiehl