@peterhashair opened this Pull Request on October 19th 2021 Contributor

Description:

Fixes: #18019

add a function in cookies. it accepts timestamp (int) and string eg: + 30 years to avoid big int in PHP 32 bit

Review

@sgiehl commented on October 19th 2021 Member

Seems there are also various tests failing...

@peterhashair commented on October 19th 2021 Contributor

@sgiehl sorry, that's my bad, it actually fired a warning instead of an error.

@peterhashair commented on October 19th 2021 Contributor

Not sure that's the best approach, it actually throws a warning to an exception enters the catch. Then reset it back.
https://github.com/matomo-org/matomo/blob/393bfa78d4c6e14eb8a30c6989248b27c70712ac/core/Cookie.php#L478

@peterhashair commented on October 23rd 2021 Contributor

@sgiehl that's looks great, let me update it.

This Pull Request was closed on October 26th 2021
Powered by GitHub Issue Mirror