Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial export option values #18174

Merged
merged 1 commit into from Oct 18, 2021
Merged

Fix initial export option values #18174

merged 1 commit into from Oct 18, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Oct 18, 2021

Description:

Using a numeric value as default seems to work in the UI. But the resulting value seems to be incorrect after the first click.
Using a boolean value as default seems to work correctly.

fixes #18172

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Oct 18, 2021
@sgiehl sgiehl added this to the 4.6.0 milestone Oct 18, 2021
@tsteur tsteur merged commit 4c8cce6 into 4.x-dev Oct 18, 2021
@tsteur tsteur deleted the fix18172 branch October 18, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix initial export option values so checkbox shows correct value
2 participants