Cache translated timezone name in enrichSite #18168
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Noticed the
getTimezoneName
method can be very slow and CPU consuming. Especiallynew DateTimeZone($timezone);
etc. Could technically cache thegetTimezoneName
method itself but figured it's a bit easier to only cache it for now inenrichSite
as we then don't need to worry about cache key for different getTimezoneName parameters etc. The method isn't a concern when called from other places. Often most sites have the same timezone so this will be an improvement. On cloud we're calling getAllSites etc more often and we noticed it had a performance impact.Review