[Vue] Migrate content-block, enriched-headline, rate-feature + related #18166
Conversation
…ty method (all untested)
…se v-model, add event parameters to createAngularAdapter, allow translate to use variadic args or one string array + rebuild
…s in between nodes while vue 3 does not
| adminContent = document.querySelector('#content.admin'); | ||
| } | ||
|
|
||
| let contentTopPosition: number; |
There was a problem hiding this comment.
I'm actually not familiar with how this is interpreted. Will contentTopPosition be initialized with null here or with 0 as it's a number?
There was a problem hiding this comment.
It should be initialized as undefined.
There was a problem hiding this comment.
Though it seems sometimes typescript complains about this, sometimes not...
There was a problem hiding this comment.
The reason for the question actually was to clarify if the default value would pass the condition below:
contentTopPosition || contentTopPosition === 0.
Before it was initialized with false. Guess undefined should work correctly as well then.
|
@diosmosis Unrelated to this PR, I get the following notice in the browser console Seems the path is your local one... |
|
@sgiehl I grepped for it and its in the source map for the polyfill build... not sure why it's using absolute paths, the build config might be wrong there... I'll take a look, thanks for mentioning it! |
|
@sgiehl should be fixed |
|
Actually it seems the recommended approach is to not include the sourcemap in production: https://webpack.js.org/configuration/devtool/, but since we distribute unminified javascript with plugins (and much of Matomo is open source), perhaps this isn't something we need to care about... cc @sgiehl @tsteur |
|
Actually, actually, since we just merge everything into one big JavaScript asset, the sourcemaps are useless in production. |
|
@sgiehl some test failures but they don't seem related |
Should we remove them from the build then, so they aren't included in the release zip? |
|
Tests seem to pass. Will merge this now. |
I guess we could, they're only really useful for development, and they'll be generated when we develop. I'll make a PR. |
Description:
Changes:
vue:property optional in scope mapping in createAngularAdapter#anchorinstead of#/anchorcauses angularjs to fail, happens on 4.x-dev too)Notes:
Note: it seems adding components does bump the the JS payload a bit. The 4 new vue component templates add about 2kb to the gzipped content. It might be good to set a threshold for when it would be good to explore either using async components or loading plugin UMD's lazily. Both are doable, but it would be easier to manage the latter option in the long run.
Review