Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix menu dropdown spacing #18165

Merged
merged 1 commit into from Oct 18, 2021
Merged

Fix menu dropdown spacing #18165

merged 1 commit into from Oct 18, 2021

Conversation

donovanglover
Copy link
Contributor

Fixes #17786. I tested the styles on https://demo.matomo.cloud (the language picker is a menuDropdown).

@tsteur tsteur added the Needs Review PRs that need a code review label Oct 18, 2021
@tsteur tsteur added this to the 4.6.0 milestone Oct 18, 2021
sgiehl
sgiehl approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@donovanglover Thanks for creating this PR. Seems to work as expected 👍

@sgiehl sgiehl merged commit 1558764 into matomo-org:4.x-dev Oct 18, 2021
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

Install routine: language changer line height improvements
4 participants
@donovanglover @sgiehl @tsteur @justinvelluppillai