Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install routine: Fix text contrast for accessibility #18164

Merged
merged 3 commits into from Oct 28, 2021
Merged

Install routine: Fix text contrast for accessibility #18164

merged 3 commits into from Oct 28, 2021

Conversation

donovanglover
Copy link
Contributor

Fixes #17785.

@Findus23 Findus23 added c: Accessibility When something is not usable for a certain group (eg missing contrast) or devices (eg smartphones). c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review labels Oct 15, 2021
@tsteur tsteur added this to the 4.6.0 milestone Oct 18, 2021
@sgiehl
Copy link
Member

sgiehl commented Oct 18, 2021

@tsteur @mattab Is this color change fine, or should we use an even darker color?
The change can be seen here: https://builds-artifacts.matomo.org/matomo-org/matomo/4.x-dev/50103/Installation_start.png

@tsteur
Copy link
Member

tsteur commented Oct 18, 2021

It could be even darker but it's good enough for me as it's better than before.

@sgiehl
Copy link
Member

sgiehl commented Oct 19, 2021

The headlines for the input boxes (.form-group label) is currently using #76838f, which is also to slightly too light. So maybe we should overwrite this in the install.css with the same value as the text so it matches.

@sgiehl
Copy link
Member

sgiehl commented Oct 20, 2021

@donovanglover can you have a look at that?

@donovanglover
Copy link
Contributor Author

I added the CSS but I don't know which page has the label. Hopefully it works!

@sgiehl
Copy link
Member

sgiehl commented Oct 21, 2021

@donovanglover It's the page to configure the database

@sgiehl
Copy link
Member

sgiehl commented Oct 28, 2021

@donovanglover seems your change did the trick. I triggered another build and it looks fine now. Will merge this one and update our UI tests afterwards. Thanks for your contribution 👍

@sgiehl sgiehl merged commit 9357cc9 into matomo-org:4.x-dev Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Accessibility When something is not usable for a certain group (eg missing contrast) or devices (eg smartphones). c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install routine UI: improve text contrast
4 participants