@donovanglover opened this Pull Request on October 15th 2021 Contributor

Fixes #17785.

@sgiehl commented on October 18th 2021 Member

@tsteur @mattab Is this color change fine, or should we use an even darker color?
The change can be seen here: https://builds-artifacts.matomo.org/matomo-org/matomo/4.x-dev/50103/Installation_start.png

@tsteur commented on October 18th 2021 Member

It could be even darker but it's good enough for me as it's better than before.

@sgiehl commented on October 19th 2021 Member

The headlines for the input boxes (.form-group label) is currently using <a href='/76838'>#76838</a>f, which is also to slightly too light. So maybe we should overwrite this in the install.css with the same value as the text so it matches.

@sgiehl commented on October 20th 2021 Member

@donovanglover can you have a look at that?

@donovanglover commented on October 20th 2021 Contributor

I added the CSS but I don't know which page has the label. Hopefully it works!

@sgiehl commented on October 21st 2021 Member

@donovanglover It's the page to configure the database

@sgiehl commented on October 28th 2021 Member

@donovanglover seems your change did the trick. I triggered another build and it looks fine now. Will merge this one and update our UI tests afterwards. Thanks for your contribution 👍

This Pull Request was closed on October 28th 2021
Powered by GitHub Issue Mirror