Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Regex check on customer dimensions #18158

Merged
merged 3 commits into from Oct 15, 2021
Merged

Add Regex check on customer dimensions #18158

merged 3 commits into from Oct 15, 2021

Conversation

peterhashair
Copy link
Contributor

@peterhashair peterhashair commented Oct 15, 2021 •
edited

Description:

Fixes:#16153

Add Regex check on customer dimensions.

Just Extraction test below changed from index_(+).html toindex_(.+).html to passed validation. Let me know if that's wrong.

Review

Peter Zhang added 2 commits October 15, 2021 14:11
add reg check on customDimensions
7338479 
add reg check on customDimensions
update regex check
57284c6 
update regex check
@peterhashair peterhashair linked an issue Oct 15, 2021 that may be closed by this pull request
Tracking request may trigger a warning when providing an invalid regex #16153
Closed
@peterhashair peterhashair added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 15, 2021
@peterhashair peterhashair added this to the 4.6.0 milestone Oct 15, 2021
update tests
efa4f10 
update tests
@peterhashair peterhashair added the Needs Review PRs that need a code review label Oct 15, 2021
@tsteur
Copy link
Member

tsteur commented Oct 15, 2021

Nice, Works 👍

@tsteur tsteur merged commit 71c98f3 into 4.x-dev Oct 15, 2021
@tsteur tsteur deleted the m-16153-invalid-regex branch October 15, 2021 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

Tracking request may trigger a warning when providing an invalid regex
2 participants
@peterhashair @tsteur