Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error cannot read property "replace" of undefined in quick search #18149

Merged
merged 2 commits into from Oct 13, 2021

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Oct 13, 2021

Description:

See below error in getTopMenuItems.

$element.attr(...) may return undefined and then it tries to call undefined.replace() which won't work.

image

Review

@tsteur tsteur added the Needs Review PRs that need a code review label Oct 13, 2021
@tsteur tsteur added this to the 4.6.0 milestone Oct 13, 2021
@justinvelluppillai justinvelluppillai merged commit b3c276e into 4.x-dev Oct 13, 2021
@justinvelluppillai justinvelluppillai deleted the quicksearch branch October 13, 2021 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants