remove remain customer variables and provider unit test #18148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove test
peterhashair
added
the
not-in-changelog
|
@peterhashair see my comment in #17973 (comment) I think what the test was trying to tell us was to adjust the method The test exception says
|
added 2 commits
October 14, 2021 12:06
revert test but alter isPluginEnabledByDefault
remove test
|
@tsteur right, sorry misread the whole paragraph |
|
👍 that looks good now. Some UI tests will need to be updated now |
update UI tests screenshot with 2 plugin removed
|
@tsteur updated UI test screenshot. I think is good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes: #17973
remove remain customer variables and provider unit test
Review