@peterhashair opened this Pull Request on October 13th 2021 Contributor

Description:

Fixes: #17973

remove remain customer variables and provider unit test

Review

@tsteur commented on October 13th 2021 Member

@peterhashair see my comment in https://github.com/matomo-org/matomo/issues/17973#issuecomment-942673683
image

I think what the test was trying to tell us was to adjust the method isPluginBundledWithCore in the plugin manager.

The test exception says

Expected that when plugin can be uninstalled (is not included in core), then the plugin is also included in the build-package.sh so it is included in the release zip. Once we no longer include this plugin in build.zip then we need to allow uninstalling these plugins by changing isPluginBundledWithCore method.

@peterhashair commented on October 13th 2021 Contributor

@tsteur right, sorry misread the whole paragraph

@tsteur commented on October 13th 2021 Member

👍 that looks good now. Some UI tests will need to be updated now

@peterhashair commented on October 14th 2021 Contributor

@tsteur updated UI test screenshot. I think is good to go

This Pull Request was closed on October 14th 2021
Powered by GitHub Issue Mirror