[Vue] utility function for creating angularjs adapters #18146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and rebuild vue files
… utility function eventually)
…ectly watch all plugin files, fix path issue in webpack externals, add vue matomo dialog use example to ExampleVue
… the chunk is not stored in the same directory as the merged asset JS)
|
Looks generally good @diosmosis . It only requires some angular test fixes as they are failing now. |
|
@diosmosis yes that included the other PR as I only looked and tested this PR but not the other one specifically (there was no needs-review label) |
|
@tsteur 👍 thanks for the reply, I closed the other PR and will merge this when the build passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The adapter code is pretty similar for most directives, so I created a utility function automatically define the angularjs adapter based on some configuration (as also suggested by @peterhashair). It works and in the long run can keep the asset size from getting too much bigger, and will potentially also cut down on time to migrate directives. But it's rather complex (mostly for directives like piwik-dialog that don't use an isolate scope), so I'm not sure how good an idea it is. @tsteur @sgiehl (or anyone else) do you have any opinions?
Review