@tsteur opened this Pull Request on October 13th 2021 Member

Description:

fix https://github.com/matomo-org/matomo/issues/17939

Review

@sgiehl commented on October 18th 2021 Member

Wondering if we also need to update https://github.com/matomo-org/matomo/blob/115527353a9e75e01aa4d263408956ae45403bea/core/Composer/ScriptHandler.php#L21 and the referenced shell script, as it still uses facebook/, while the package now uses lox/

@tsteur commented on October 18th 2021 Member

@sgiehl changed those. Not really sure though it's generally still needed.

@sgiehl commented on October 19th 2021 Member

If it's not needed, guess we should simply remove it. There also seems to be a build-xhprof.sh, not sure what it was good for and why it is not called in ScriptHandler::buildXhprof 🤷
Btw. Guess it might be needed to run a composer update after this was merged, otherwise it might remain in the dev packages in composer.lock.

@tsteur commented on October 19th 2021 Member

I removed these scripts for now. We can always add back if needed for some reason.

This Pull Request was closed on October 20th 2021
Powered by GitHub Issue Mirror