@peterhashair opened this Pull Request on October 12th 2021 Contributor

Description:

Fixes: #17919
update SEO tests, It seems the print $_SERVER['REMOTE_ADDR'] doesn't give back the useful info.

bing-index expected non-zero rank, got [0], ip [127.0.0.1]

Review

@tsteur commented on October 12th 2021 Member

feel free to merge later @peterhashair 👍

@peterhashair commented on October 13th 2021 Contributor

Did quite a lot of tests and research,

I think the SEO tests randomly failed is because Bing is a dynamic system with an anti crawler, our crawler exceeds the number of trying in a period of time it will return a page like this.

I Update bing getMetrics when there is no result instead of return 0, return a general error that should skip the tests

image

@peterhashair commented on October 13th 2021 Contributor

@tsteur Bing doesn't return an error status, it loads through javascript. I don't think it will change too much. Only when someone did a website that does not exist will display an error page. It seems like maybe this error needs a little bit of update on the code. Every search engine looks different, let me know if we want to update this.
image

@tsteur commented on October 13th 2021 Member

i see. Didn't realise others were already showing that simple error message. Possibly they don't error as often. We've had errors before on the cloud for bing so this happens more often. It be great to possibly use the same consistent message possibly. Even if it's just like an Error. Please try again later.

@peterhashair commented on October 13th 2021 Contributor

@tsteur Sure, that should fix the SEO test and the error page.
image

This Pull Request was closed on October 14th 2021
Powered by GitHub Issue Mirror