@peterhashair
Description:
Fixes: #17919
update SEO tests, It seems the print $_SERVER['REMOTE_ADDR'] doesn't give back the useful info.
bing-index expected non-zero rank, got [0], ip [127.0.0.1]
Review
- [ ] Functional review done
- [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- [ ] Security review done
- [ ] Wording review done
- [ ] Code review done
- [ ] Tests were added if useful/possible
- [ ] Reviewed for breaking changes
- [ ] Developer changelog updated if needed
- [ ] Documentation added if needed
- [ ] Existing documentation updated if needed
@tsteur
feel free to merge later @peterhashair 👍
Did quite a lot of tests and research,
I think the SEO tests randomly failed is because Bing is a dynamic system with an anti crawler, our crawler exceeds the number of trying in a period of time it will return a page like this.
I Update bing getMetrics when there is no result instead of return 0, return a general error that should skip the tests
@tsteur Bing doesn't return an error status, it loads through javascript. I don't think it will change too much. Only when someone did a website that does not exist will display an error page. It seems like maybe this error needs a little bit of update on the code. Every search engine looks different, let me know if we want to update this.
i see. Didn't realise others were already showing that simple error message. Possibly they don't error as often. We've had errors before on the cloud for bing so this happens more often. It be great to possibly use the same consistent message possibly. Even if it's just like an Error. Please try again later.
@tsteur Sure, that should fix the SEO test and the error page.