@AltamashShaikh opened this Pull Request on October 12th 2021 Contributor

Added functionality to filter getReportMetadata and getSegmentsMetada in SystemTestCase
Issue: #DEV-2366

Description:

Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.

Review

@sgiehl commented on October 18th 2021 Member

@AltamashShaikh I think it might be useful to add or change a test in core that uses that new possibility so we can directly see how and if it works. That might also prevent future regressions. You could for example change the custom dimension tests: https://github.com/matomo-org/matomo/blob/d7dced0928c7457f4e14fb571d897ac927b95134/plugins/CustomDimensions/tests/System/ApiTest.php#L162

This Pull Request was closed on October 26th 2021
Powered by GitHub Issue Mirror