Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ZipArchive when available #1814

Closed
robocoder opened this issue Nov 12, 2010 · 4 comments
Closed

Use ZipArchive when available #1814

robocoder opened this issue Nov 12, 2010 · 4 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
1.1

Comments

@robocoder
Copy link
Contributor

We should use the native 'zip' extension when available (instead of PclZip) because it's faster.

See WordPress wp-admin/includes/file.php unzip_file() wrapper, and _unzip_file_ziparchive() implementation.
@robocoder
Copy link
Contributor Author

(In [3312]) fixes #1814

@robocoder
Copy link
Contributor Author

(In [3313]) refs #1814 - add another test to make sure the factory method works

@mattab
Copy link
Member

mattab commented Dec 23, 2010

Anthon, can you please confirm that both use cases have been tested with auto update? is the new auto-update webtest covering one use case already maybe?

@robocoder
Copy link
Contributor Author

Unit tests cover the actual unzipping for both implementations.
Webtest covers the high level use case, as the underlying implementation has been abstracted.

@robocoder robocoder added this to the Piwik 1.1 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
2 participants
@mattab @robocoder