Remove root array correctly for jsonp API requests #18136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinvelluppillai
added
not-in-changelog
|
@justinvelluppillai could you add a test for this one for JSONP to ensure we still get correct output for JSONP? Could add a test for the API method that the user reported in the issue ( |
|
@tsteur I've made a few changes in agreement with @tomudding's recent comment, and also added tests where they seemed most sensible (not sure if that was exactly where you were meaning to add tests in your comment?) |
justinvelluppillai
changed the title
|
That's what I meant. Tested it also and works |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #18133 regression
Review