@justinvelluppillai opened this Pull Request on October 12th 2021 Contributor

Description:

Fixes #18133 regression

Review

@tsteur commented on October 12th 2021 Member

@justinvelluppillai could you add a test for this one for JSONP to ensure we still get correct output for JSONP? Could add a test for the API method that the user reported in the issue (Overlay.getTranslations).

@justinvelluppillai commented on October 12th 2021 Contributor

@tsteur I've made a few changes in agreement with @tomudding's recent comment, and also added tests where they seemed most sensible (not sure if that was exactly where you were meaning to add tests in your comment?)

@tsteur commented on October 12th 2021 Member

That's what I meant. Tested it also and works

This Pull Request was closed on October 12th 2021
Powered by GitHub Issue Mirror