Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] migrate piwik-dialog + a couple other fixes #18127

Closed
wants to merge 25 commits into from
Closed

[Vue] migrate piwik-dialog + a couple other fixes #18127

wants to merge 25 commits into from

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Oct 11, 2021 •
edited

Description:

This PR is based off of #18114

Changes:

  • Migrate piwik-dialog directive with an adapter.
  • Use MatomoDialog component in ExampleVue to show how it works (as it is different from piwik-dialog).
  • Fix issue in vue:build --watch command, make sure it runs all watch commands in parallel if watching changes in every plugin.
  • Fix configuration of externals in vue.config.js, a path was not changed when the file was changed.

image

Review

@diosmosis
incomplete conversion
fcedcd8
@diosmosis
migrate ajax helper + piwik URL
efb9ae0
@diosmosis
get ajax helper migration to work
3677655
@diosmosis
delete old periods.spec.js
6e92e29
@diosmosis
remove global-ajax-queue.js file
94c54f2
@diosmosis
migrate piwik service and test (w/ hacks to get it the test to work)
37ef1ae
@diosmosis
rebuild and remove old files + get tests to pass
7c5416a
@diosmosis
unfinished commit
79f81ec
@diosmosis
return jqxhr object so promise api can be used
445ab7a
@diosmosis
move hasBlockedContent and deprecate piwikApi service
d23b885
@diosmosis
remove alert files
088b35e
@diosmosis
convert piwikHelper.spec.js
70ed58c
@diosmosis
in new vue code, use "Matomo" everywhere possible instead of "piwik" …
8874007 
…and rebuild vue files
@diosmosis
Merge branch '4.x-dev' into vue-piwik-api2
86032b8
@diosmosis
add another needed export line in command
0260057
@diosmosis
include polyfills after vue so we can add to vue engine
bd766ae
@diosmosis
Add HTML sanitizer for use w/ migrating ng-bind-html uses.
6e40a48
@diosmosis
fix broken merge, rebuild js, fix issue in build command
ec9ebdb
@diosmosis
add sanitize to other components for consistency (will be replaced by…
35607a3 
… utility function eventually)
@diosmosis
migrate matomo-dialog, fix issue where vue:build --watch did not corr…
13da356 
…ectly watch all plugin files, fix path issue in webpack externals, add vue matomo dialog use example to ExampleVue
@diosmosis diosmosis added this to the 4.6.0 milestone Oct 11, 2021
@diosmosis diosmosis changed the title [Vue] migrate piwik-dialog w/ BC adapter + a couple other fixes [Vue] migrate piwik-dialog + a couple other fixes Oct 11, 2021
@diosmosis diosmosis mentioned this pull request Oct 14, 2021
Merged
11 tasks
@diosmosis
Copy link
Member Author

Closing this and merging #18127

@diosmosis diosmosis closed this Oct 15, 2021
@diosmosis diosmosis deleted the vue-dialog branch October 15, 2021 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@diosmosis