Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEOTest failed print REMOTE_ADDR #18125

Merged
merged 3 commits into from Oct 11, 2021
Merged

Conversation

peterhashair
Copy link
Contributor

Description:

Fixes: #17919
SEOTest failed print REMOTE_ADDR

Review

failed print  REMOTE_ADDR
@tsteur
Copy link
Member

tsteur commented Oct 11, 2021

I don't think printing the Travis IP be any concern so all good 👍

Peter Zhang added 2 commits October 11, 2021 16:37
convert ip to a variable
update ip variable
@peterhashair peterhashair marked this pull request as ready for review October 11, 2021 20:25
@peterhashair peterhashair added this to the 4.6.0 milestone Oct 11, 2021
@peterhashair peterhashair added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 11, 2021
@peterhashair peterhashair merged commit 910cb09 into 4.x-dev Oct 11, 2021
@peterhashair peterhashair deleted the m-17919-print-ip-on-seo-test branch October 11, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SEO Ranking plugin not working - problem with ping? - Fix the random test failures
3 participants