Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unify duplicated translation string #18121

Merged
merged 1 commit into from Oct 10, 2021
Merged

unify duplicated translation string #18121

merged 1 commit into from Oct 10, 2021

Conversation

Findus23
Copy link
Member

@Findus23 Findus23 commented Oct 9, 2021

#18077 created a new translation string for a text that already exists in Matomo causing translators to translate the same text again (and potentially differently this time)

This should remove that string again.

Review

@Findus23 Findus23 added the Needs Review PRs that need a code review label Oct 9, 2021
@sgiehl sgiehl added this to the 4.6.0 milestone Oct 10, 2021
@sgiehl sgiehl added c: i18n For issues around internationalisation and localisation. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels Oct 10, 2021
@sgiehl sgiehl merged commit edcf050 into 4.x-dev Oct 10, 2021
@sgiehl sgiehl deleted the unify-duplicated-string branch October 10, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
c: i18n For issues around internationalisation and localisation. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Findus23 @sgiehl