Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed fake access check when idsite=0 returning true #18116

Merged
merged 1 commit into from Oct 8, 2021
Merged

Fixed fake access check when idsite=0 returning true #18116

merged 1 commit into from Oct 8, 2021

Conversation

AltamashShaikh
Copy link
Contributor

Description:

Fixed fake access check when idsite=0
Fixes: #18115

Review

@AltamashShaikh AltamashShaikh added the Needs Review PRs that need a code review label Oct 8, 2021
@AltamashShaikh AltamashShaikh added this to the 4.6.0 milestone Oct 8, 2021
@sgiehl sgiehl merged commit f15bd27 into 4.x-dev Oct 8, 2021
@sgiehl sgiehl deleted the fakeAccess-Site_comparison-fix branch October 8, 2021 19:35
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

FakeAccess update idsite comparison for all to strict
3 participants
@AltamashShaikh @sgiehl @justinvelluppillai