add write to adding_segment_requires_access #18113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add write to adding_segment_requires_access
|
Needs a UI test update then it should be good to merge 👍 |
|
@tsteur I check the test before, but I can't find the one that failed related to that change. |
|
@peterhashair whenever we change the global config file, then there would be always be an expected config file screenshot failure test. In this case it is https://builds-artifacts.matomo.org/matomo-org/matomo/4.x-dev/49822/UIIntegrationTest_admin_diagnostics_configfile.png |
added 2 commits
October 11, 2021 09:03
update screen shot
justinvelluppillai
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes: #18107
add write to adding_segment_requires_access
Review