@peterhashair opened this Pull Request on October 8th 2021 Contributor

Description:

Fixes: #18107

add write to adding_segment_requires_access

Review

@tsteur commented on October 8th 2021 Member

Needs a UI test update then it should be good to merge 👍

@peterhashair commented on October 8th 2021 Contributor

@tsteur I check the test before, but I can't find the one that failed related to that change.

@tsteur commented on October 10th 2021 Member

@peterhashair whenever we change the global config file, then there would be always be an expected config file screenshot failure test. In this case it is https://builds-artifacts.matomo.org/matomo-org/matomo/4.x-dev/49822/UIIntegrationTest_admin_diagnostics_configfile.png
image

This Pull Request was closed on October 11th 2021
Powered by GitHub Issue Mirror